Skip to content

🎨 Palette: Add empty state for results list - #479

Draft
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-empty-state-results-list-8633601385416335638
Draft

🎨 Palette: Add empty state for results list#479
xbmc4lyfe wants to merge 1 commit into
mainfrom
palette-empty-state-results-list-8633601385416335638

Conversation

@xbmc4lyfe

@xbmc4lyfe xbmc4lyfe commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

💡 What

Added an empty state label to the results dialog that displays "No results found." when there are no items in the list.

🎯 Why

In Kodi XML skins, custom lists do not automatically handle empty states, resulting in a confusing blank screen when no items are present. This provides clear feedback to the user.

📸 Before/After

Before: Blank dark screen when no results.
After: Centered "No results found." text.

♿ Accessibility

Improves clarity and feedback for users when a search yields no results.

PR created automatically by Jules for task 8633601385416335638 started by @xbmc4lyfe

@google-labs-jules @xbmc4lyfe
Add empty state for results list
ed2e313 
Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
@google-labs-jules

google-labs-jules Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the addon label Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5dcf6c4e-e6be-4cb1-9df1-7c62e7c391bc

📥 Commits

Reviewing files that changed from the base of the PR and between 000221a and ed2e313.

📒 Files selected for processing (1)
  • repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (7)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: coverage
  • GitHub Check: lint
  • GitHub Check: test
  • GitHub Check: Scan
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (python)
🔇 Additional comments (1)
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml (1)

271-280: LGTM!

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a centered “No results found.” message when the results list is empty.

Walkthrough

The results dialog now shows a centered “No results found.” label when its results list contains no items.

Changes

Results empty state

Layer / File(s) Summary
Empty-state label rendering
repo/plugin.video.nzbdav/resources/skins/Default/1080i/results-dialog.xml		 Adds a centered, muted label visible when Container(50).NumItems equals zero.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ponchopig

Poem

A bunny hops where results hide,
“No results found,” floats soft and wide.
The empty screen now greets the day,
With gentle text to light the way.
Hop hop hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes adding an empty state for the results list.
Description check ✅ Passed The description directly explains the empty-state label, its purpose, behavior, and user benefit.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette-empty-state-results-list-8633601385416335638
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch palette-empty-state-results-list-8633601385416335638

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested a review from PonchoPig July 31, 2026 00:31
@codacy-production

codacy-production Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-code-quality

github-code-quality Bot commented Jul 31, 2026

Copy link
Copy Markdown

Code Coverage Overview

Languages: Python

Python / code-coverage/pytest

The overall coverage in commit ed2e313 in the palette-empty-state-... branch remains at 88%, unchanged from commit 000221a in the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@PonchoPig PonchoPig Awaiting requested review from PonchoPig

Assignees

No one assigned

Labels

addon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@xbmc4lyfe